[SDK] fix: Skip swap approvals and use local gas prices #6182

joaquim-verges · 2025-02-06T07:20:06Z

PR-Codex overview

This PR focuses on enhancing the thirdweb package by adding a new FiatProvider option, optimizing button rendering in several screens, improving gas price handling, and refining error message management for better user feedback during transactions.

Detailed summary

Added "COINBASE" to FiatProvider type.
Simplified button rendering in FiatStatusScreen and SwapStatusScreen.
Refined transaction request handling in ConfirmationScreen to manage gas prices locally.
Implemented approval check in getQuote.ts.
Improved error message handling in BuyScreen and FiatScreen.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot · 2025-02-06T07:20:11Z

🦋 Changeset detected

Latest commit: f5b4fe1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
thirdweb	Patch
@thirdweb-dev/wagmi-adapter	Patch
thirdweb-login	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-02-06T07:20:12Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 6, 2025 8:41am
login	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 6, 2025 8:41am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 6, 2025 8:41am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 6, 2025 8:41am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 6, 2025 8:41am

joaquim-verges · 2025-02-06T07:20:27Z

[SDK] fix: Skip swap approvals and use local gas prices #6182 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

graphite-app · 2025-02-06T07:21:43Z

packages/thirdweb/src/pay/buyWithCrypto/getQuote.ts

    const data: BuyWithCryptoQuoteRouteResponse = (await response.json())
      .result;

+    // check if the fromAddress already has approval for the given amoutn


Typo in comment: amoutn should be amount. Consider using a spell checker to catch these small issues before committing.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx

github-actions · 2025-02-06T07:24:56Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	46.68 KB (+0.18% 🔺)	934 ms (+0.18% 🔺)	1.8 s (+96.42% 🔺)	2.8 s
thirdweb (cjs)	122.56 KB (+0.15% 🔺)	2.5 s (+0.15% 🔺)	3.1 s (-8.12% 🔽)	5.5 s
thirdweb (minimal + tree-shaking)	5.58 KB (0%)	112 ms (0%)	84 ms (-50.47% 🔽)	196 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	28 ms (-9.29% 🔽)	38 ms
thirdweb/react (minimal + tree-shaking)	19.29 KB (0%)	386 ms (0%)	338 ms (+9.46% 🔺)	724 ms

joaquim-verges marked this pull request as ready for review February 6, 2025 07:20

joaquim-verges requested review from a team as code owners February 6, 2025 07:20

github-actions bot assigned joaquim-verges Feb 6, 2025

github-actions bot added Playground Changes involving the Playground codebase. packages SDK Involves changes to the thirdweb SDK labels Feb 6, 2025

joaquim-verges force-pushed the _SDK_fix_Skip_swap_approvals_and_use_local_gas_prices branch from d07de97 to f39e0ab Compare February 6, 2025 07:21

graphite-app bot reviewed Feb 6, 2025

View reviewed changes

packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx Outdated Show resolved Hide resolved

vercel bot deployed to Preview – wallet-ui February 6, 2025 07:25 View deployment

vercel bot deployed to Preview – thirdweb_playground February 6, 2025 07:25 View deployment

vercel bot deployed to Preview – login February 6, 2025 07:26 View deployment

vercel bot deployed to Preview – thirdweb-www February 6, 2025 07:30 View deployment

vercel bot deployed to Preview – docs-v2 February 6, 2025 07:31 View deployment

joaquim-verges force-pushed the _SDK_fix_Skip_swap_approvals_and_use_local_gas_prices branch from f39e0ab to f0c5a54 Compare February 6, 2025 07:46

vercel bot deployed to Preview – wallet-ui February 6, 2025 07:49 View deployment

vercel bot deployed to Preview – login February 6, 2025 07:49 View deployment

vercel bot deployed to Preview – thirdweb_playground February 6, 2025 07:51 View deployment

vercel bot deployed to Preview – docs-v2 February 6, 2025 07:53 View deployment

vercel bot deployed to Preview – thirdweb-www February 6, 2025 07:55 View deployment

gregfromstl approved these changes Feb 6, 2025

View reviewed changes

[SDK] fix: Skip swap approvals and use local gas prices

f5b4fe1

joaquim-verges force-pushed the _SDK_fix_Skip_swap_approvals_and_use_local_gas_prices branch from f0c5a54 to f5b4fe1 Compare February 6, 2025 08:31

vercel bot deployed to Preview – wallet-ui February 6, 2025 08:34 View deployment

vercel bot deployed to Preview – login February 6, 2025 08:34 View deployment

vercel bot deployed to Preview – thirdweb_playground February 6, 2025 08:34 View deployment

joaquim-verges merged commit f77165e into main Feb 6, 2025
26 of 30 checks passed

joaquim-verges deleted the _SDK_fix_Skip_swap_approvals_and_use_local_gas_prices branch February 6, 2025 08:36

joaquim-verges mentioned this pull request Feb 6, 2025

Version Packages #6166

Merged

vercel bot deployed to Preview – docs-v2 February 6, 2025 08:38 View deployment

vercel bot deployed to Preview – thirdweb-www February 6, 2025 08:41 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] fix: Skip swap approvals and use local gas prices #6182

[SDK] fix: Skip swap approvals and use local gas prices #6182

Uh oh!

joaquim-verges commented Feb 6, 2025 •

edited by pr-codex bot

Loading

Uh oh!

changeset-bot bot commented Feb 6, 2025 •

edited

Loading

Uh oh!

vercel bot commented Feb 6, 2025 •

edited

Loading

Uh oh!

joaquim-verges commented Feb 6, 2025

Uh oh!

graphite-app bot Feb 6, 2025

Uh oh!

Uh oh!

github-actions bot commented Feb 6, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[SDK] fix: Skip swap approvals and use local gas prices #6182

[SDK] fix: Skip swap approvals and use local gas prices #6182

Uh oh!

Conversation

joaquim-verges commented Feb 6, 2025 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

changeset-bot bot commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joaquim-verges commented Feb 6, 2025

How to use the Graphite Merge Queue

Uh oh!

graphite-app bot Feb 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

joaquim-verges commented Feb 6, 2025 •

edited by pr-codex bot

Loading

changeset-bot bot commented Feb 6, 2025 •

edited

Loading

vercel bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading